Skip to content

Glasgow | 25 SDC NOV | Katarzyna Kazimierczuk | Sprint 2 | Lru cache#118

Open
katarzynakaz wants to merge 6 commits intoCodeYourFuture:mainfrom
katarzynakaz:lru-cache
Open

Glasgow | 25 SDC NOV | Katarzyna Kazimierczuk | Sprint 2 | Lru cache#118
katarzynakaz wants to merge 6 commits intoCodeYourFuture:mainfrom
katarzynakaz:lru-cache

Conversation

@katarzynakaz
Copy link

@katarzynakaz katarzynakaz commented Feb 20, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Sprint 2 lru cache task is implemented.

@katarzynakaz katarzynakaz added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 20, 2026
cjyuan
cjyuan reviewed Feb 26, 2026
View reviewed changes
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you implement the LruCache as a class?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 26, 2026
@katarzynakaz katarzynakaz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 2, 2026
cjyuan
cjyuan reviewed Mar 2, 2026
View reviewed changes
@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 2, 2026
@katarzynakaz katarzynakaz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 3, 2026
cjyuan
cjyuan reviewed Mar 3, 2026
View reviewed changes
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is correct. I think it still have some rooms for improvement.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 3, 2026
@katarzynakaz
Copy link
Author

katarzynakaz commented Mar 4, 2026

requested changes are made

@katarzynakaz katarzynakaz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 4, 2026
cjyuan
cjyuan reviewed Mar 4, 2026
View reviewed changes
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 4, 2026
@katarzynakaz
Copy link
Author

katarzynakaz commented Mar 4, 2026

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@katarzynakaz @cjyuan